Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E scripts cause unnecessary rolling restart of the operator by patching log level #2296

Open
rzetelskik opened this issue Jan 3, 2025 · 2 comments · May be fixed by #2297
Open

E2E scripts cause unnecessary rolling restart of the operator by patching log level #2296

rzetelskik opened this issue Jan 3, 2025 · 2 comments · May be fixed by #2297
Assignees
@rzetelskik
Labels
kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@rzetelskik
Copy link
Member

rzetelskik commented Jan 3, 2025 •
edited
Loading

The log level adjustment in the e2e func

scylla-operator/hack/.ci/lib/e2e.sh

Lines 215 to 218 in cc08f3e

# Raise loglevel in CI.
# TODO: Replace it with ScyllaOperatorConfig field when available.
kubectl -n=scylla-operator patch --field-manager="${FIELD_MANAGER}" deployment/scylla-operator --type=json -p='[{"op": "add", "path": "/spec/template/spec/containers/0/args/-", "value": "--loglevel=4"}]'
kubectl -n=scylla-operator rollout status deployment/scylla-operator

causes an unnecessary rolling restart of the operator. It prevents us from giving operator guaranteed QoS in CI with resources >= half of what's available because PDB blocks the restart and everything gets stuck.

We should move this to CI scripts to avoid the rolling restart.

Perhaps together with #836. Edit: until we have managed SM it wouldn't simplify things too much, so this is unrelated.

/kind machinery
@scylla-operator-bot scylla-operator-bot bot added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 3, 2025
@rzetelskik rzetelskik linked a pull request Jan 3, 2025 that will close this issue
Open
@rzetelskik
Copy link
Member Author

/lifecycle frozen
/assign

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 7, 2025
@rzetelskik
Copy link
Member Author

/priority important-soon

@scylla-operator-bot scylla-operator-bot bot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzetelskik rzetelskik

Labels
kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
1 participant
@rzetelskik