Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var_names/obs_names as fixed-size types #172

Open
rcannood opened this issue Jul 8, 2024 · 1 comment
Open

var_names/obs_names as fixed-size types #172

rcannood opened this issue Jul 8, 2024 · 1 comment
Labels
design Discussion about how things should be designed

Comments

@rcannood
Copy link
Collaborator

rcannood commented Jul 8, 2024

At some point, the var_names and obs_names could be something other than strings in Python (See scverse/anndata#777). R data frames can only have characters as rownames, so we'll need to find a workaround.

Originally, we decided to not use the rownames of obs and var in anticipation for the aforementioned feature, but I reverted this in #171 to make the code cleaner / easier to read for now.

@rcannood rcannood added the design Discussion about how things should be designed label Jul 8, 2024
@rcannood
Copy link
Collaborator Author

rcannood commented Jul 8, 2024

As noted by @lazappi in #171 (comment):

I would probably make a special man page and/or vignette for things we know are different from Python.

I totally agree! If #777 is merged, we should add this to the list of known incompatibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Discussion about how things should be designed
Projects
None yet
Development

No branches or pull requests

1 participant