Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE Keyboard Merge #346

Merged
merged 6 commits into from
Jul 20, 2023
Merged

DE Keyboard Merge #346

merged 6 commits into from
Jul 20, 2023

Conversation

nyfz18
Copy link
Contributor

@nyfz18 nyfz18 commented Jul 20, 2023

Contributor checklist


Description

Related issue

Added expanded DE keyboard settings

nyfz18 added 6 commits July 12, 2023 18:03
Updated iPad keyboard only to include the snake symbol (sorry haha I don't know what that's called), indent, uppercase, and assigned the leftKeyChars and rightKeyChars with the respective keys
Added letterKeysPadExpanded
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review July 20, 2023 17:32
@andrewtavis
Copy link
Member

Hey @nyfz18! Made some comments above :) I'd also be happy to merge and fix these errors myself, and then you can use the German keyboard as a basis for the PRs for the other languages 😊

@nyfz18
Copy link
Contributor Author

nyfz18 commented Jul 20, 2023

sure! In that case, I'll get started with the other keyboards!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion, approving the current commits and will send along some changes to fix that then @nyfz18 can implement for future PRs 😊

@andrewtavis
Copy link
Member

Will send along the changes for this shortly and write in the issue, @nyfz18!

@andrewtavis andrewtavis merged commit d87bca3 into scribe-org:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants