Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iPad] Wrong popup for some keys on larger iPad models #509

Closed
2 tasks done
christianbilodeau opened this issue Oct 1, 2024 · 4 comments
Closed
2 tasks done

[iPad] Wrong popup for some keys on larger iPad models #509

christianbilodeau opened this issue Oct 1, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@christianbilodeau
Copy link
Contributor

Terms

Behavior

Some characters should be considered to be "left" or "right" key characters on larger iPad models (see xInterfaceVariables.swift files)

For example, this \ should show a "left" popup:

Screenshot 2024-10-01 at 15 20 45

And this * should show a "right" popup:

Screenshot 2024-10-01 at 15 21 11

Device type

iPad

Versions

iOS 17.5.1 & Scribe 3.1.1

@christianbilodeau christianbilodeau added the bug Something isn't working label Oct 1, 2024
@christianbilodeau
Copy link
Contributor Author

I can tackle this one

@christianbilodeau
Copy link
Contributor Author

PR opened here. Doing the changes I uncovered a separate issue about repeating keys :)

@andrewtavis
Copy link
Member

Thanks so much for all the issues, @christianbilodeau! 🚀 Looking forward to the review :)

@andrewtavis
Copy link
Member

Closed via #511 🚀 Thanks so much for a great contribution, @christianbilodeau! Hope we'll be able to work with you again 😊 Please feel free to open issues anytime!

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants