Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Delete Keys on IPad #366

Closed
2 tasks done
stilianb opened this issue Oct 5, 2023 · 4 comments
Closed
2 tasks done

Multiple Delete Keys on IPad #366

stilianb opened this issue Oct 5, 2023 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@stilianb
Copy link
Contributor

stilianb commented Oct 5, 2023

Terms

Behavior

In the current main branch, all keyboards (not including Hebrew, Danish, and Norwegian) have multiple delete keys within their respective interfaces on IPad.

Here's an example of the issue:
deletekeybug

letterKeys[0].append("delete") within each languages interface seems to be appending another delete key for IPad layouts.

The earliest instance I could find of this change being made was in #33.

Removing this line in each interface seems to solve the issue.

Device type

iPad

Versions

iOS 17, Scribe 2.3.0

@stilianb stilianb added the bug Something isn't working label Oct 5, 2023
@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 7, 2023
@andrewtavis andrewtavis moved this to Todo in Scribe Board Oct 7, 2023
@andrewtavis
Copy link
Member

Hey @stilianb! Thanks so much for pointing this out 😊 Would you have interest in working on this?

@stilianb
Copy link
Contributor Author

stilianb commented Oct 7, 2023

Yes! I'd be happy to.

@andrewtavis
Copy link
Member

andrewtavis commented Oct 7, 2023

Fantastic, @stilianb! Assigning you now :) Please let me know if there's anything I can do to help 😊

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Oct 7, 2023
@andrewtavis
Copy link
Member

andrewtavis commented Oct 16, 2023

Closed by #367! Thanks for opening the issue and sending along a fix, @stilianb! As I said in the PR, I'll finalize these conditions soon so that they're reflective of the new expanded keyboard mechanics :)

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants