-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Support import of provisioners from private OCI/image registry #56
Comments
I like the dynamic login approach which is also mentioned here: https://github.com/oras-project/oras-go/blob/main/example_test.go#L121 , It can also improve the user experience :) |
Yeah if it's easy enough and we already have the code in the oras library, then we should do this 👍 |
Actually, we need to support the access to private oci registry, which is not in place yet, so re-opening ;) |
So is it open to work again?:) |
Ah Apologies @mathieu-benoit - let me edit the description a little to make this clear. @7h3-3mp7y-m4n yes please go ahead |
Now that we support the import of provisioners from public OCI registry/image with #48, let's now support the import of provisioners from private OCI registry/image.
High level flow to support this:
Currently, the oci provisioner import does not inherit the docker creds or any other registry sessions, so private registries cannot be used.
Thoughts here but open to suggestion, we should just support the dynamic login approach ("using Docker credentials") like illustrated here: https://github.com/oras-project/oras-go/blob/main/example_test.go#L106, as opposed to support static approach like with user/passwork or token.
The text was updated successfully, but these errors were encountered: