Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Support import of provisioners from private OCI/image registry #56

Open
mathieu-benoit opened this issue Oct 18, 2024 · 6 comments · May be fixed by #60
Open

[bug] Support import of provisioners from private OCI/image registry #56

mathieu-benoit opened this issue Oct 18, 2024 · 6 comments · May be fixed by #60
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Oct 18, 2024

Now that we support the import of provisioners from public OCI registry/image with #48, let's now support the import of provisioners from private OCI registry/image.

High level flow to support this:

$ docker login|oras login...
$ ...--import oci.//...

Currently, the oci provisioner import does not inherit the docker creds or any other registry sessions, so private registries cannot be used.

Thoughts here but open to suggestion, we should just support the dynamic login approach ("using Docker credentials") like illustrated here: https://github.com/oras-project/oras-go/blob/main/example_test.go#L106, as opposed to support static approach like with user/passwork or token.

@mathieu-benoit mathieu-benoit added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 18, 2024
@mathieu-benoit mathieu-benoit changed the title [feature request] Support import of provisioners from private OCI [feature request] Support import of provisioners from private OCI registry Oct 18, 2024
@mathieu-benoit mathieu-benoit changed the title [feature request] Support import of provisioners from private OCI registry [feature request] Support import of provisioners from private OCI/image registry Oct 18, 2024
@mathieu-benoit mathieu-benoit moved this to In Progress in KubeCon NA 2024 SLC Oct 18, 2024
@mathieu-benoit mathieu-benoit moved this from In Progress to Todo in KubeCon NA 2024 SLC Oct 18, 2024
@7h3-3mp7y-m4n
Copy link
Contributor

7h3-3mp7y-m4n commented Oct 20, 2024

I like the dynamic login approach which is also mentioned here: https://github.com/oras-project/oras-go/blob/main/example_test.go#L121 , It can also improve the user experience :)
And I would love to work on it :)

@astromechza
Copy link
Member

Yeah if it's easy enough and we already have the code in the oras library, then we should do this 👍

@astromechza
Copy link
Member

done in #48 and #59

@mathieu-benoit
Copy link
Contributor Author

Actually, we need to support the access to private oci registry, which is not in place yet, so re-opening ;)

@7h3-3mp7y-m4n
Copy link
Contributor

So is it open to work again?:)

@astromechza
Copy link
Member

Ah Apologies @mathieu-benoit - let me edit the description a little to make this clear.

@7h3-3mp7y-m4n yes please go ahead

@astromechza astromechza added the bug Something isn't working label Nov 11, 2024
@astromechza astromechza changed the title [feature request] Support import of provisioners from private OCI/image registry [bug] Support import of provisioners from private OCI/image registry Nov 11, 2024
@mathieu-benoit mathieu-benoit linked a pull request Nov 19, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants