Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change @POST to @GET for "merge-check" #71

Open
40rn05lyv opened this issue May 4, 2020 · 1 comment
Open

Change @POST to @GET for "merge-check" #71

40rn05lyv opened this issue May 4, 2020 · 1 comment

Comments

@40rn05lyv
Copy link

src/main/java/com/cloudogu/scm/review/pullrequest/api/MergeResource.java#check currently can be accessed via @POST, although it doesn't perform any changes to the server.
It's probably can be changed to @GET.
@pfeuffer
Copy link
Member

pfeuffer commented May 4, 2020

Good point. We will check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pfeuffer @40rn05lyv