Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ikiwiki's style.css breaks pandoc table headers #16

Open
per-review opened this issue Sep 30, 2016 · 1 comment
Open

ikiwiki's style.css breaks pandoc table headers #16

per-review opened this issue Sep 30, 2016 · 1 comment

Comments

@per-review
Copy link

I already posted this bug on ikiwiki.info, but there has been no response (from anyone, I mean). I don't know what the most elegant fix would be, but I think changing the source generated by pandoc is a bad one.

This may, strictly speaking, be a bug in the [[plugins/contrib/pandoc]] plugin, but I think it would be better to fix it in ikiwiki because of its kind (and maybe because I believe/hope pandoc will become the markdown dialect standard). For all I know it might not only affect pandoc tables.

When creating a simple table in pandoc-flavoured markdown,

1    2
---  ---
3    4

pandoc converts this to the html code

<table>
<thead>
<tr class="header">
<th align="left">1</th>
<th align="left">2</th>
</tr>
</thead>
<tbody>
<tr class="odd">
<td align="left">3</td>
<td align="left">4</td>
</tr>
</tbody>
</table>

<tr class="header"> causes it to be affected by style.css's

.header {
    margin: 0;
    font-size: 140%;
    font-weight: bold;
    line-height: 1em;
    display: block;
}

(more specifically by display: block;), which results in all header cells to cramp together in the first column.

The fix is easy: In style.css change .header { to .header tr:not(.header) {.

Alternatively, add the following code.

tr.header {
    display: table-row;
    }

I've added that last code snippet to my custom.css file. I admit .header tr:not(.header) is not especially elegant, but then again, I have almost no knowledge of CSS. There might be better solutions. (I don't even know why display: block; breaks the tables or why changing it to display: table-header; doesn't fix it but display: table-row; does :D )

@bk
Copy link
Collaborator

bk commented Sep 30, 2016

This kind of conflict is not surprising with third-party plugins. I suggest you simply add the css file local.css to your wiki, with a style override such as:

tr.header {
    display: table-row;
    font-size: 100%;
    line-height: 1.1;
}

A bit more about css usage in ikiwiki can be found here. As a rule it is not good to change style.css directly since it is apt to be overwritten later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants