Support private uploads #5
Conversation
Sanity-check the structure of hop_auth responses more carefully.
There was a problem hiding this comment.
This looks fine, but my preference would be to just create an endpoint in scimma-admin to get the information you want in a single request, rather than use a multi-request to make two requests fast. It looks like here your trying to get the permissions and details of a topic? That seems reasonable to expose all together in an endpoint to me...
|
The two things being queried here are not very closely related; one is the properties of the topic itself and the other are the permissions the current user has with respect to that topic. I think it's indicative that these are in completely separate database tables, internally, so while it would be possible to make one route that returned both, I would struggle to figure out what it should even be named, as it wouldn't have a single, well-defined purpose, where the existing routes are, to the extent possible, designed to be orthogonal and independent. |
|
Thinking about this a bit more it occurs to me to describe it as: The REST API needs to support all relevant 'fundamental' operations, and the multi-request is exactly a general purpose system to allow composition of any combination of those, instead of having to hard-code each combination that we discover is relevant when we want it. |
Implements #4 .
Depends on scimma/scimma-admin#67 .