feat: Support hist/hist division if view supports it #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #302 - Histogram/histogram division is supported using the trick recommended by @HDembinski - the work of division is passed to the view. There are two items that need to be addressed: Accumulator views should support division if that makes sense for them, and if Unlimited is upgraded so that a view does not convert it instantly to double, then this will likely need special handling (probably triggering that conversion in this case, actually). Those are beyond the scope of this PR.
After this, we will start the process for the 0.8.0 release - the SciPy Video has already gone live.