Update submodule and fix broken items #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2024 13:43
Committing the Gemfile lock into the knapsack makes Hyku gem updates not take effect as they should.
added 3 commits
November 19, 2024 15:11
Remove unneeded Move some to Hyku Document overrides
added 2 commits
November 21, 2024 15:52
sjproctor
approved these changes
Nov 21, 2024
spec/rails_helper.rb
Outdated
| @@ -35,7 +35,7 @@ | |||
|
|
|||
| RSpec.configure do |config| | |||
| # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures | |||
| config.fixture_path = "#{::Rails.root}/spec/fixtures" | |||
| config.fixture_path = Rails.root.join("spec", "fixtures").to_s | |||
There was a problem hiding this comment.
You might want single quotes here since you removed the interpolation
There was a problem hiding this comment.
Odd... that was a rubocop auto-fix! I wouldn't have expected it to use double quotes.
added 2 commits
November 21, 2024 17:55
PR samvera/hyku#2384 added a new account setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
After updating the Hyku submodule, there are some issues to resolve before merging.
Refs #164
Expected Behavior Before Changes
Expected Behavior After Changes
Screenshots / Video
Notes