Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Leverage CopyGenerator to ensure we have local copy #285

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

jeremyf
Copy link
Contributor

@jeremyf jeremyf commented Nov 8, 2023

We need to address the case where SpaceStone failed to copy the file
into S3. When the file does not exist in S3, we can check if we have
the file locally and use that as the pre-processed location. Otherwise,
we can copy the original remote file and proceed.

Related to:

We need to address the case where SpaceStone failed to copy the file
into S3.  When the file does not exist in S3, we can check if we have
the file locally and use that as the pre-processed location.  Otherwise,
we can copy the original remote file and proceed.

Related to:

- #283
- #282
@jeremyf jeremyf requested a review from orangewolf November 8, 2023 21:53
kirkkwang added a commit to notch8/adventist-dl that referenced this pull request Nov 8, 2023
This commit updates IIIF Print, details referenced below.

Ref:
  - notch8/iiif_print#285
@orangewolf orangewolf merged commit e492798 into main Nov 15, 2023
4 checks passed
@orangewolf orangewolf deleted the copy-missing-space-stone-files branch November 15, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants