Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen up rails restriction #281

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Loosen up rails restriction #281

merged 4 commits into from
Nov 6, 2023

Conversation

orangewolf
Copy link
Contributor

There doesn't look like anything that's Rails 5 dependent here.

@jeremyf jeremyf merged commit 652cc43 into main Nov 6, 2023
9 of 10 checks passed
@laritakr laritakr deleted the rails_version branch November 22, 2023 16:36
jeremyf added a commit that referenced this pull request Nov 27, 2023
@jeremyf
⚙️ Remove hard-dependency on Rails
a57c3c3 
Hyrax already assumes a dependency on Rails, let's defer to that.

With #281, we noticed that the initial build went from 9 minutes or so
to 45+ minutes.  The hope is that this can reduce that build time.

Related to:

- #281
@jeremyf jeremyf mentioned this pull request Nov 27, 2023
Merged
jeremyf added a commit that referenced this pull request Nov 27, 2023
@jeremyf
⚙️ Remove hard-dependency on Rails
789ab36 
Hyrax already assumes a dependency on Rails, let's defer to that.

With #281, we noticed that the initial build went from 9 minutes or so
to 45+ minutes.  The hope is that this can reduce that build time.

Related to:

- #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkkwang kirkkwang kirkkwang approved these changes

Assignees
No one assigned
Labels
patch-ver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orangewolf @kirkkwang @jeremyf