♻️ Ensure we pass query to IIIF viewer #280
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the later versions of Hyku, they override the Hyrax view of
app/views/catalog/_index_header_list_default.html.erb
; so IIIF Print'sstrategy of overriding that view does not work. (Because Hyku's view
path rightly takes higher precedence than any Gem).
Looking at the updated view, the URL is generated via a helper method.
So our approach to adding the parent_query or query parameter leverages
extending the helper method.
We still need the view override, as it reflects a prior state of
Hyku (and Hyrax) that some implementations will continue to use.
Below is a diff of the files in Hyku v5.0.1 and IIIF Print. I
have not resolved all of these things but am close:
diff of the files in Hyku v5.0.1 and IIIF Print
Co-authored-by: Kirk Wang [email protected]