From 1f2c9c754f36699bbff302eb3902cfb3cd93274c Mon Sep 17 00:00:00 2001 From: LaRita Robinson Date: Fri, 8 Nov 2024 13:07:10 -0500 Subject: [PATCH] Fix lint errors --- app/jobs/iiif_print/jobs/child_works_from_pdf_job.rb | 2 +- .../split_pdfs/child_work_creation_from_pdf_service.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/jobs/iiif_print/jobs/child_works_from_pdf_job.rb b/app/jobs/iiif_print/jobs/child_works_from_pdf_job.rb index a1d20aa1..fb2a6621 100644 --- a/app/jobs/iiif_print/jobs/child_works_from_pdf_job.rb +++ b/app/jobs/iiif_print/jobs/child_works_from_pdf_job.rb @@ -33,7 +33,7 @@ def perform(id, pdf_paths, user, admin_set_id, *) # However, there seem to be cases where we still don't have the file when we get here, so to be sure, we # re-do the same command that was previously used to prepare the file path. If the file is already here, it # simply returns the path, but if not it will copy the file there, giving us one more chance to have what we need. - redownload = pdf_file_set && pdf_file_set.is_a?(ActiveFedora::Base) + redownload = pdf_file_set&.is_a?(ActiveFedora::Base) pdf_paths = [Hyrax::WorkingDirectory.find_or_retrieve(pdf_file_set.original_file.id, pdf_file_set.id, pdf_paths.first)] if redownload # handle each input pdf (when input is a file set, we will only have one). pdf_paths.each do |original_pdf_path| diff --git a/lib/iiif_print/split_pdfs/child_work_creation_from_pdf_service.rb b/lib/iiif_print/split_pdfs/child_work_creation_from_pdf_service.rb index 02d39ab5..a17032f7 100644 --- a/lib/iiif_print/split_pdfs/child_work_creation_from_pdf_service.rb +++ b/lib/iiif_print/split_pdfs/child_work_creation_from_pdf_service.rb @@ -21,7 +21,7 @@ class ChildWorkCreationFromPdfService # # @return [Symbol] when we don't enqueue the job # @return [TrueClass] when we actually enqueue the job underlying job. - # rubocop:disable Metrics/MethodLength + # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity def self.conditionally_enqueue(file_set:, file:, user:, import_url: nil, work: nil) work ||= IiifPrint.parent_for(file_set) @@ -47,7 +47,7 @@ def self.conditionally_enqueue(file_set:, file:, user:, import_url: nil, work: n ) job ? :enqueued : :pdf_job_failed_enqueue end - # rubocop:enable Metrics/MethodLength + # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity ## # @api private