Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blade: Provide Factory Service over ContractFactory instead of Factory #57

Open
alexander-schranz opened this issue Nov 13, 2022 · 0 comments
Open

Blade: Provide Factory Service over ContractFactory instead of Factory #57

alexander-schranz opened this issue Nov 13, 2022 · 0 comments
Labels
Engine: Blade Blade engine and integration

Comments

@alexander-schranz
Copy link
Contributor

Currently the service definition which is used is:

use Illuminate\View\Factory;

But as shown by @butschster here: https://github.com/schranz-templating/templating/pull/56/files#diff-7aeef8d8c609cf605db9f3d3ef26adacdbe09dee1fd4f4c974b26519ea770b79R122-R127

There exist also:

use Illuminate\Contracts\View\Factory as FactoryContract;

Which instead could be used.

Requires: illuminate/contracts.
@alexander-schranz alexander-schranz added the Engine: Blade Blade engine and integration label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engine: Blade Blade engine and integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexander-schranz