Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisableBroadcast property could be dynamic #21

Open
kubasiemion opened this issue Feb 23, 2021 · 1 comment
Open

DisableBroadcast property could be dynamic #21

kubasiemion opened this issue Feb 23, 2021 · 1 comment

Comments

@kubasiemion
Copy link

Hi,
We started using the framework to quickly span multiple nodes for some MPC tests, and we really really like it. It allows us to mostly forget about the network setup. Great work!
What would be nice is a little of dynamic management, especially Broadcast and Interval. Or, alternatively, a slightly better restart capability (some go routines like listen() are tricky ). Would you accept such a PR for a review?
Cheers!

@schollz
Copy link
Owner

schollz commented Feb 23, 2021

Hi @kubasiemion I'm happy to accept any PR! Basically if its good for you, its good for me. The only "review" I do is to make sure it still works with croc. Don't worry about changing the API either - if you want to do it, do it and then itll be a v2 release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants