Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script doesn't load under HTTPS (mixed-mode content) #79

Open
FineWolf opened this issue Oct 11, 2013 · 6 comments
Open

Script doesn't load under HTTPS (mixed-mode content) #79

FineWolf opened this issue Oct 11, 2013 · 6 comments

Comments

@FineWolf
Copy link

When loading Google Analytics, your script is failing due to the fact that you are importing GA always under http. If you load the profiler under HTTPS, the whole profiler will fail due to the inclusion of GA with http.

Simply load GA using a scheme-less URL

dom.createDom('script', {'src': '//www.google-analytics.com/ga.js', 'type': 'text/javascript'});
@stof
Copy link
Contributor

stof commented Oct 11, 2013

this is a bit more complex, because the SSL versions of GA is at https://ssl.google-analytics.com/ga.js according to their doc

@schmittjoh
Copy link
Owner

I think we can remove the entire GA code as was discussed in some other thread.

@mayeco
Copy link

mayeco commented Nov 27, 2014

@schmittjoh can you please remove this tracking feature.

@schmittjoh
Copy link
Owner

We can remove this code, someone just needs to send a PR. I don't have the time unfortunately.

@mayeco
Copy link

mayeco commented Nov 27, 2014

@schmittjoh working on that

@mayeco
Copy link

mayeco commented Nov 27, 2014

done PR #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants