Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

runners can access admin-scoped PAT #7

Open
scottlamb opened this issue Sep 1, 2022 · 0 comments
Open

runners can access admin-scoped PAT #7

scottlamb opened this issue Sep 1, 2022 · 0 comments

Comments

@scottlamb
Copy link

scottlamb commented Sep 1, 2022

First, thanks for writing this!

I'm doing a quick audit. I see that:

  • the readme describes making a "Github Personal Access Token with workflow and admin:org scopes".
  • the runner VMs are allowed to read that token.
  • AFAICT, they only use that token to create a short-lived/less-privileged registration token.

Could the registration tokens be created from the webhook instead and passed in to the VMs on launch? and that IAM policy be put only on the webhook, not the VM? Then if hostile code sneaks into the build, it can't get persistent admin access (this way, at least).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant