Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed marker #1000

Closed
dorak88783 opened this issue Aug 5, 2024 · 8 comments · Fixed by #1001
Closed

Add py.typed marker #1000

dorak88783 opened this issue Aug 5, 2024 · 8 comments · Fixed by #1001

Comments

@dorak88783
Copy link

After the addition of typing information, it'd be nice to add a py.typed marker file (https://peps.python.org/pep-0561/)

@MartinPacker
Copy link

Do "we" prereq 3.7? Do "we" need to? (My code that builds on python-pptx already goes beyond that - to 3.8 - using the Walrus operator.)

@scanny
Copy link
Owner

scanny commented Aug 5, 2024

@dorak88783 Yep, it occurred to me over the weekend I'd left out that critical last step after the marathon of type annotation! Adding in a maintenance release here: #1001

@scanny
Copy link
Owner

scanny commented Aug 5, 2024

@MartinPacker where are you seeing 3.7? I was figuring to support 3.8 at the earliest, just because some Linux distros might still ship with that.

@scanny
Copy link
Owner

scanny commented Aug 5, 2024

@MartinPacker I checked PyPI and all seems to be in order that this release requires 3.8 as a minimum. If folks need older than that they can pin to a prior version. My plan is to support only supported Python versions with each release.

@MartinPacker
Copy link

@scanny there was a link that suggested 3.7. I'm hoping we're way beyond that. As to whether features such as Walrus Operators are exploited (or useful) I couldn't say.

@scanny
Copy link
Owner

scanny commented Aug 5, 2024

Can you point me to the link @MartinPacker ?

@MartinPacker
Copy link

This one (above) https://peps.python.org/pep-0561/

@scanny
Copy link
Owner

scanny commented Aug 6, 2024

Ah okay, I think I see what you're saying now @MartinPacker. Yes, we start "official" support at Python 3.8 (first version tested) so I think we're good on that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants