Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BERTE-561 skip the merge through the queue when not needed #158

Merged
merged 14 commits into from
Jan 29, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jan 18, 2024

This pull request primarily focuses on improving the queuing system in the bert_e project. The main changes include modifying the pull request handling logic to check if queuing is necessary.

@bert-e
Copy link
Contributor

bert-e commented Jan 18, 2024

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 18, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

@tcarmet tcarmet marked this pull request as ready for review January 26, 2024 18:49
@tcarmet tcarmet requested a review from a team as a code owner January 26, 2024 18:49
@tcarmet tcarmet changed the base branch from development/3.10 to development/3.11 January 26, 2024 19:12
@tcarmet tcarmet changed the title BERTE-561 try skipping the merge through the queue when not needed BERTE-561 skip the merge through the queue when not needed Jan 26, 2024
Copy link
Contributor

@nootal nootal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but my knowledge in this area is limited

@tcarmet
Copy link
Contributor Author

tcarmet commented Jan 29, 2024

LGTM but my knowledge in this area is limited

My knowledge as well 😅 , what I would ask is, if you can think of a high level scenario that I haven't covered, would be happy to write it up. (doesn't have to be now, can be later on as we work with the release of the feature).

@tcarmet tcarmet merged commit 653081a into development/3.11 Jan 29, 2024
9 checks passed
@tcarmet tcarmet deleted the feature/BERTE-561-skip-queue-when-not-needed branch January 31, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants