feat(ipam): show private ips on resources #2759

yfodil · 2024-10-02T06:42:36Z

No description provided.

codecov-commenter · 2024-10-03T20:07:48Z

Codecov Report

Attention: Patch coverage is 84.48276% with 36 lines in your changes missing coverage. Please review.

Project coverage is 71.40%. Comparing base (fe86049) to head (9619f51).
Report is 199 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/services/ipam/helpers.go	71.42%	4 Missing and 4 partials ⚠️
internal/services/k8s/pool.go	85.00%	3 Missing and 3 partials ⚠️
internal/services/instance/private_nic.go	87.09%	2 Missing and 2 partials ⚠️
internal/services/instance/server.go	77.77%	2 Missing and 2 partials ⚠️
internal/services/redis/cluster.go	80.00%	2 Missing and 2 partials ⚠️
internal/services/vpcgw/network.go	88.23%	2 Missing and 2 partials ⚠️
internal/services/baremetal/server.go	86.66%	1 Missing and 1 partial ⚠️
internal/services/lb/lb.go	86.66%	1 Missing and 1 partial ⚠️
internal/services/rdb/instance.go	93.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   71.43%   71.40%   -0.04%     
==========================================
  Files         277      328      +51     
  Lines       35875    33151    -2724     
==========================================
- Hits        25628    23672    -1956     
+ Misses       8028     7215     -813     
- Partials     2219     2264      +45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…orm-provider-scaleway into feat/private-ip-management

Codelax · 2024-10-07T15:26:36Z

internal/services/baremetal/server.go

+		privateNetworkIDs = append(privateNetworkIDs, pn.PrivateNetworkID)
+	}
+
+	var allPrivateIPs []map[string]interface{}


nit: Considering server will have at least 1 IP per connected private network. This should be allocated for the minimum size.

Codelax · 2024-10-07T15:33:28Z

internal/services/rdb/instance.go

 	if pnI, pnExist := flattenPrivateNetwork(res.Endpoints); pnExist {
 		_ = d.Set("private_network", pnI)
+
+		if res.Endpoints[0].PrivateNetwork.ProvisioningMode == rdb.EndpointPrivateNetworkDetailsProvisioningModeIpam {


Can the first endpoint be something else than a private network ? res.Endpoints[0].PrivateNetwork may be nil

remyleone · 2024-10-08T09:37:15Z

internal/services/baremetal/server.go

+						"address": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The private IP address",


I would precise that it is an IPv4

remyleone · 2024-10-08T09:37:48Z

internal/services/instance/private_nic.go

+						"id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The ID of the IP address resource",


I would precise it is an IPv4

remyleone · 2024-10-08T09:37:53Z

internal/services/instance/private_nic.go

+						"address": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The private IP address",


I would precise it is an IPv4

remyleone · 2024-10-08T09:38:05Z

internal/services/instance/server.go

+						"id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The ID of the IP address resource",


I would precise it is an IPv4

remyleone · 2024-10-08T09:38:10Z

internal/services/instance/server.go

+						"address": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The private IP address",


I would precise it is an IPv4

remyleone · 2024-10-08T09:38:21Z

internal/services/k8s/pool.go

+						"id": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The ID of the IP address resource",


I would precise it is an IPv4

remyleone · 2024-10-08T09:38:26Z

internal/services/k8s/pool.go

+						"address": {
+							Type:        schema.TypeString,
+							Computed:    true,
+							Description: "The private IP address",


I would precise it is an IPv4

remyleone · 2024-10-08T09:38:53Z

docs/resources/instance_server.md

@@ -252,6 +252,10 @@ attached to the server. Updates to this field will trigger a stop/start of the s
 - `private_network` - (Optional) The private network associated with the server.
   Use the `pn_id` key to attach a [private_network](https://www.scaleway.com/en/developers/api/instance/#path-private-nics-list-all-private-nics) on your instance.

+- `private_ip` - The list of private IP addresses associated with the resource.
+    - `id` - The ID of the IP address resource.
+    - `address` - The private IP address.


I would precise it is an IPv4

remyleone · 2024-10-08T09:41:10Z

internal/services/baremetal/server.go

@@ -244,6 +246,25 @@ If this behaviour is wanted, please set 'reinstall_on_ssh_key_changes' argument
 					},
 				},
 			},
+			"private_ip": {


Would plural make sense here if it is a list?

feat(ipam): show private ips on resources

0b33647

yfodil added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Oct 2, 2024

yfodil self-assigned this Oct 2, 2024

yfodil and others added 2 commits October 2, 2024 08:44

Merge branch 'master' into feat/private-ip-management

58c737d

fixes and lint

7595a71

SebUndefined mentioned this pull request Oct 3, 2024

Redis data source does not send all informations about the cluster #2760

Open

update cassettes

7ae769b

github-actions bot added the iot IoT issues, bugs and feature requests label Oct 3, 2024

yfodil added 2 commits October 3, 2024 21:07

update cassettes

0f1f66e

update cassettes

c75938c

yfodil marked this pull request as ready for review October 4, 2024 07:53

yfodil requested review from jremy42, Mia-Cross, Codelax, Laure-di and remyleone as code owners October 4, 2024 07:53

yfodil and others added 3 commits October 4, 2024 09:53

Merge branch 'master' into feat/private-ip-management

644b8ee

fix

d04b097

Merge branch 'feat/private-ip-management' of github.com:yfodil/terraf…

9619f51

…orm-provider-scaleway into feat/private-ip-management

Codelax reviewed Oct 7, 2024

View reviewed changes

remyleone reviewed Oct 8, 2024

View reviewed changes

remyleone marked this pull request as draft October 28, 2024 14:55

remyleone added the priority:high New features label Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ipam): show private ips on resources #2759

feat(ipam): show private ips on resources #2759

yfodil commented Oct 2, 2024

codecov-commenter commented Oct 3, 2024 •

edited

Loading

Codelax Oct 7, 2024

Codelax Oct 7, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

remyleone Oct 8, 2024

feat(ipam): show private ips on resources #2759

Are you sure you want to change the base?

feat(ipam): show private ips on resources #2759

Conversation

yfodil commented Oct 2, 2024

codecov-commenter commented Oct 3, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Oct 3, 2024 •

edited

Loading