Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LowercasePatternMatchChecker should not warn when matched variable is used in result #33

Open
FlashSheridan opened this issue Sep 25, 2018 · 0 comments

Comments

@FlashSheridan
Copy link

In the examples for LowercasePatternMatchChecker, the lower-case match is obviously a mistake, since the variable masks an existing one, and is not used on the right side of the “=>”. But in scanning our existing code base, there were multiple reports where the code behaved as intended, and the match was actually used.
I accept that avoiding lower-case variables in this situation may be useful style for a new code base, but our uses are not actual semantic problems. It would be useful to be able to suppress these warnings, without suppressing genuine bugs where an existing variable is masked by a lower-case match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant