-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar navigation for Japanese docs #762
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josh-wong I left some comments. I noticed Reference
s were wrongly translated to 管理
. I put some suggestions on them, but I didn't consider consistency. So feel free change them. Also, I think Authorization
should be translated to 認可
when it's used with Authentication
.
sidebars.js
Outdated
{ | ||
type: 'doc', | ||
id: 'run-non-transactional-storage-operations-through-primitive-crud-interface', | ||
label: 'プリミティブ CRUD インターフェースを使用して実行する', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directly translated プリミティブ
sounds a bit odd to me. Maybe we don't need to mention primitive
in this case?
label: 'プリミティブ CRUD インターフェースを使用して実行する', | |
label: 'CRUD インターフェースを使用して実行する', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@komamitsu Sorry, I had a translation in the wrong place and had forgotten to translate the label above that one. I've fixed that in 2ce715b.
Since one of the earlier titles is labeled as CRUD インターフェースを使用して実行する
, I think we should keep this as プリミティブ CRUD インターフェースを使用して実行する
. Is that OK?
053b0d9
to
2ce715b
Compare
2ce715b
to
7c1de4c
Compare
Co-authored-by: Mitsunori Komatsu <[email protected]>
@komamitsu Thank you for your review! I've applied your suggestions in c08ceab. PTAL when you have time🙇🏻♂️ |
b2cc7c7
to
6550b79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
I left two suggestions.
Please take a look when you have time! 🙇♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Co-authored-by: kota2and3kan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@feeblefakie As you suggested, I applied 体言止め throughout. PTAL! |
bd8f99e
to
eca1bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Caution
This PR should not be merged until after we're ready to add the
displayed_sidebar: docsEnglish
configuration to the front-matter properties of English docs anddisplayed_sidebar: docsJapanese
configuration to the front-matter properties of Japanese docs. By adding this configuration, we can specify the appropriate sidebar language that should be displayed for the respective language when the visitor is on a page.This method follows Docusaurus's method for sidebars, as described in Understanding sidebar association.
Description
This PR adds sidebar navigation for Japanese docs for ScalarDB 3.13 and 3.14. Since we hard-code the titles in the sidebar navigation for the English docs, which were the only docs we had up until recently, the Japanese docs default to the English titles in the sidebar navigation. Because of this, we need to have sidebars for both languages.
See an example of the sidebar navigation at:
In addition, with the sidebar being in Japanese, the version dropdown menu should also be displayed in Japanese when visiting docs in Japanese.
Related issues and/or PRs
Note
Similar changes are being done in the ScalarDB docs:
Changes made
docs
todocsEnglish
.docsJapanese
) that matches the English docs.labels
) in thedocsJapanese
sidebar into Japanese.Checklist
N/A
Additional notes (optional)
N/A