Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macro annotations used in the same compilation run lead to confusion #13

Open
xeno-by opened this issue Dec 22, 2013 · 2 comments
Open

macro annotations used in the same compilation run lead to confusion #13

xeno-by opened this issue Dec 22, 2013 · 2 comments
Labels
critical

Comments

@xeno-by
Copy link
Member

xeno-by commented Dec 22, 2013

They just won't expand, without any sort of a warning or error message
@xeno-by xeno-by mentioned this issue Mar 21, 2014
Closed
@xeno-by
Copy link
Member Author

xeno-by commented Mar 22, 2014

This is similar to a bigger problem that is about macro annotations not expanding if paradise is not enabled, which is fixed in 2.11.0, where macro annotations are automatically annotated with @compileTimeOnly and can't be fixed in 2.10.x without modifying the compiler.

upd. Well, sort of fixed, because @compileTimeOnly errors are only reported if typechecking has been successful, so compilation errors stemming from absense of members that should've been expanded will still be confusing.

@xeno-by xeno-by modified the milestones: 2.1.0-final, 2.0.0-final Mar 22, 2014
@xeno-by xeno-by removed this from the 2.2.0-final milestone Nov 19, 2015
@xeno-by
Copy link
Member Author

xeno-by commented Nov 19, 2015

Marking this as critical, because a lot of people encounter this and making their life easier would be very welcome. I hope I get time to address this problem in 2.2.x.

SethTisue pushed a commit to scalacommunitybuild/paradise that referenced this issue Nov 21, 2017
@xeno-by
fix scalamacros#13
80c1777 
I was very surprised to find that mod filtering is actually unnecessary.
It turns out we can remove it and everything works out magically.

But then I rememberd that filtering was only necessary because of a hack
that we had in place when we didn't have the converter working. Now,
when we have a converter, the hack for a hack can go away.
SethTisue pushed a commit to scalacommunitybuild/paradise that referenced this issue Nov 21, 2017
@xeno-by
Merge pull request scalamacros#31 from xeno-by/2.11.8
92f7905 
fix scalamacros#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xeno-by