Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on the Flamegraph git project based in the Center organization #71

Closed
danicheg opened this issue Dec 24, 2023 · 10 comments
Closed
Labels
behind-the-scenes Relates to appreciated but not user-facing changes

Comments

@danicheg
Copy link
Collaborator

At the moment, scalac-profiling depends on the fork of Flamegraph, which is seemingly abandoned and hasn't been updated for 5+ years. It'd be beneficial if someone could create a fresh fork based in the Center organization. Who can assist with that? cc @SethTisue @sjrd

@danicheg danicheg added the behind-the-scenes Relates to appreciated but not user-facing changes label Dec 24, 2023
@SethTisue
Copy link
Collaborator

curious what the nature of the changes is... is it anything that could be upstreamed?

@danicheg
Copy link
Collaborator Author

curious what the nature of the changes is... is it anything that could be upstreamed?

  1. Update the Flamegraph library we depend on.
  2. Generally be able to develop/update our fork on demand. It's barely that Jorge is interested in it.
  3. Cut down the abandoned dependencies.

@danicheg
Copy link
Collaborator Author

danicheg commented Jan 1, 2024

@SethTisue any thoughts on this?

@SethTisue
Copy link
Collaborator

curious what the nature of the changes is

what I meant by this was, what is the nature of the changes that Jorge made in the fork? perhaps Jorge's changes could be submitted to https://github.com/brendangregg/FlameGraph and if they were merged, then having a fork would no longer be necessary

It'd be beneficial if someone could create a fresh fork based in the Center organization

seems reasonable to me (even as a temporary measure if we also pursue the upstreaming idea), but I don't have admin rights in scalacenter/*, so @sjrd would have to take care of it

@danicheg
Copy link
Collaborator Author

danicheg commented Jan 9, 2024

@sjrd would you mind taking a look at this issue?

@sjrd
Copy link
Contributor

sjrd commented Jan 9, 2024

I'm on sick leave this week so I can't really look into stuff. But if you tell me exactly what you need me to do I can do it. Or ask someone else with admin rights on scalacenter, such as @adp2 or @anatoliykmetyuk

@danicheg
Copy link
Collaborator Author

danicheg commented Jan 9, 2024

@sjrd Be well soon! I'm wondering about doing these two particular things:

  1. Fork the https://github.com/brendangregg/FlameGraph into Center Github org;
  2. Create a branch scala-compilation based on the master branch and push it into the origin.

I will do the rest of the stuff. It'd be great if you folks @adpi2 @anatoliykmetyuk could do that. Thank you!

@sjrd
Copy link
Contributor

sjrd commented Jan 9, 2024

I forked FlameGraph and made you Maintainer, like for this repo. As far I can tell that should let you do step 2 yourself. (I did not truly understand what branch from what repo to push to what branch?)

@danicheg
Copy link
Collaborator Author

danicheg commented Jan 9, 2024

Cool, thanks again.

@danicheg
Copy link
Collaborator Author

Done in #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behind-the-scenes Relates to appreciated but not user-facing changes
Projects
None yet
Development

No branches or pull requests

3 participants