-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depends on the Flamegraph git project based in the Center organization #71
Comments
curious what the nature of the changes is... is it anything that could be upstreamed? |
|
@SethTisue any thoughts on this? |
what I meant by this was, what is the nature of the changes that Jorge made in the fork? perhaps Jorge's changes could be submitted to https://github.com/brendangregg/FlameGraph and if they were merged, then having a fork would no longer be necessary
seems reasonable to me (even as a temporary measure if we also pursue the upstreaming idea), but I don't have admin rights in scalacenter/*, so @sjrd would have to take care of it |
@sjrd would you mind taking a look at this issue? |
I'm on sick leave this week so I can't really look into stuff. But if you tell me exactly what you need me to do I can do it. Or ask someone else with admin rights on |
@sjrd Be well soon! I'm wondering about doing these two particular things:
I will do the rest of the stuff. It'd be great if you folks @adpi2 @anatoliykmetyuk could do that. Thank you! |
I forked |
Cool, thanks again. |
Done in #84 |
At the moment,
scalac-profiling
depends on the fork of Flamegraph, which is seemingly abandoned and hasn't been updated for 5+ years. It'd be beneficial if someone could create a fresh fork based in the Center organization. Who can assist with that? cc @SethTisue @sjrdThe text was updated successfully, but these errors were encountered: