Fixed broken "Scala 3" sub menu on mobile #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSS doesn't support id selector containing whitespace, see https://github.com/scala/docs.scala-lang/blob/d626b36e217a99ee078cdcfbc30d23386dc7fb00/resources/js/functions.js#L90
|
CI failure isn't caused by this PR. |
bishabosha
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Thank you for taking the time to contribute here!
confirming that I can indeed click the menu item now on narrow screens. I tried to see if there could be a clash with scala3 ids elsewhere, but I think it's safe.
Another option could be replace with __, _ or - possibly?
All are fine, the js script doesn’t hard code the id, I prefer simple word “scala3”. Thanks for your merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS doesn't support id selector containing whitespace, see
docs.scala-lang/resources/js/functions.js
Line 90 in d626b36