Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing pull-requests for retracted versions #3445

Open
mzuehlke opened this issue Oct 19, 2024 · 1 comment · May be fixed by #3488
Open

Closing pull-requests for retracted versions #3445

mzuehlke opened this issue Oct 19, 2024 · 1 comment · May be fixed by #3488
Labels
enhancement New feature or request

Comments

@mzuehlke
Copy link
Member

It happens to the best developers that they release a a new version premature. Scala 3.6.0 was just the last example.
The https://github.com/scala-steward-org/scala-steward/blob/main/modules/core/src/main/resources/default.scala-steward.conf lists multiple blocked artifacts.

The idea is to close pull requests of artifacts that get listed in updates.retracted and/or leave at lest a comment that this version shouldn't be used. The affected should be stored in the PullRequestRepository.

@scala-steward-org/core @WojciechMazur @SethTisue @Kordyjan

@mzuehlke mzuehlke added the enhancement New feature or request label Oct 19, 2024
@fthomas
Copy link
Member

fthomas commented Oct 19, 2024

Great idea! The entries in updates.retracted could contain an optional reason why a version was retracted and/or an URL that contains further information.

mzuehlke added a commit that referenced this issue Nov 24, 2024
The `updates.retraced` section of the `scala-steward.conf` allows to declare updates that should be retracted. Each entry must have a `reason, a `doc` URL and a list of dependency patterns.

Example:
```
updates.retracted = [
  {
    reason = "Ignore version 3.6.0 as it is abandoned due to broken compatibility",
    doc = "https://contributors.scala-lang.org/t/broken-scala-3-6-0-release/6792",
    artifacts = [
      { groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.6.0" } }
    ]
  }
]
```
Retraction of Pull Request is only possible, if the workspace is persisted correctly. (https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#why-doesnt-self-hosted-scala-steward-close-obsolete-prs)

Fixes: #3445
@mzuehlke mzuehlke linked a pull request Nov 24, 2024 that will close this issue
mzuehlke added a commit that referenced this issue Nov 24, 2024
The `updates.retraced` section of the `scala-steward.conf` allows to declare updates that should be retracted. Each entry must have a `reason, a `doc` URL and a list of dependency patterns.

Example:
```
updates.retracted = [
  {
    reason = "Ignore version 3.6.0 as it is abandoned due to broken compatibility",
    doc = "https://contributors.scala-lang.org/t/broken-scala-3-6-0-release/6792",
    artifacts = [
      { groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.6.0" } }
    ]
  }
]
```
Retraction of Pull Request is only possible, if the workspace is persisted correctly. (https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#why-doesnt-self-hosted-scala-steward-close-obsolete-prs)

Fixes: #3445
mzuehlke added a commit that referenced this issue Nov 24, 2024
The `updates.retraced` section of the `scala-steward.conf` allows to declare updates that should be retracted. Each entry must have a `reason, a `doc` URL and a list of dependency patterns.

Example:
```
updates.retracted = [
  {
    reason = "Ignore version 3.6.0 as it is abandoned due to broken compatibility",
    doc = "https://contributors.scala-lang.org/t/broken-scala-3-6-0-release/6792",
    artifacts = [
      { groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.6.0" } }
    ]
  }
]
```
Retraction of Pull Request is only possible, if the workspace is persisted correctly. (https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#why-doesnt-self-hosted-scala-steward-close-obsolete-prs)

Fixes: #3445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants