Challenge 1 extension #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rin-st
reviewed
Dec 4, 2024
extension/README.md.args.mjs
Outdated
| > in a second terminal window, 🛰 deploy your contract (locally): | ||
|
|
||
| \`\`\`sh | ||
| cd challenge-1-decentralized-staking |
extension/README.md.args.mjs
Outdated
| > in a third terminal window, start your 📱 frontend: | ||
|
|
||
| \`\`\`sh | ||
| cd challenge-1-decentralized-staking |
| </div> | ||
| `; | ||
|
|
||
| export const externalExtensionName = "SpeedRunEthereum Challenge #1"; |
There was a problem hiding this comment.
please add empty line at the end of this file and other files when you see that minus sign. If you use vscode/cursor add this to your settings "files.insertFinalNewline": true
There was a problem hiding this comment.
Added empty line and added the config to settings. Thanks!
Thanks!! Changes done! |
Pabl0cks
reviewed
Dec 5, 2024
extension/packages/nextjs/app/staker-ui/_components/EthToPrice.tsx
Outdated
Show resolved
Hide resolved
Thanks!! Changes done. Anyway, if you try to deploy to Vercel you have to resolve the challenge first to get no errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Challenge 1 migrated to an extension following #234
Closes #235