Add shell script for prod deployments + modify Makefile accordingly #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR:
-> adds a shell script to give the user a menu for selecting a keystore when deploying to any network other than the local anvil node
-> modifies the makefile to pass in the RPC_URL from the foundry.toml file to the shell script
-> works in linux and macos, since foundry does not work on windows natively, windows is ignored. So we should test this on: linux + wsl + macos
-> removes the need to modify the .env file when changing keystores to use
Possible To-Do:
-> ‘—keystore’ flag (thx to Shiv for the suggestion) I have some working code on this, but it accepts variables like this:
yarn deploy --network sepolia my-keystoreinstead of
yarn deploy --network sepolia --keystore my-keystoreWe can also introduce a new script as I couldn't find how to achieve this without doing so. Tried passing in another flag in the package.json, but did not work.