RC 1.3.4 with automatic_addressbook

[j4jes]

I went ahead and upgraded Roundcube to v1.3.4 from the remi repo and now my mobile skins and automatic_addressbook aren't working. I did the < sql-initial, and I see the collected_contacts table in the RC database, but when I tail -f through the roundcube logs I don't see anything relevant that indicates it is trying to write to the table when sending an email from the web interface.

Is there a version of automatic_addressbook that is more likely to work with Roundcube 1.3.4 ? I'm using the latest one.

Tx

[thoatswold]

I was able to get automatic_addressbook to work on Roundcube 1.3.6 eventually. My system is Ubuntu 18.04. Here are the steps I followed:

[1] Installed the plugin using composer:
[a] added it to /usr/share/roundcube/composer.json as the last entry under 'require':
"sblaisot/automatic_addressbook": "~0.4.3"
[b] cd /usr/share/roundcube && php composer.phar update

[2] Composer threw an error when running the mysql.initial.sql file, so I did this manually in mysql:
USE roundcube;
source ./SQL/mysql.initial.sql;

[3] The plugin uses the old 'rcmail' instead of 'rcube', so I backed up the plugin folder and did a search & replace:
...
cd plugins
rsync -av ./automatic_addressbook/ ./automatic_addressbook.bak
cd automatic_addressbook
find . -type f -name '*.php' -exec sed -i -e "s/rcmail/rcube/g" {} \;
...

[4] Create a symlink of the plugin source directory in /var/lib/roundcube/plugins/:
ln -s /usr/share/roundcube/plugins/automatic_addressbook/ /var/lib/roundcube/plugins/

[5] Edit the Roundcube config file and add the plugin reference to enable it:
nano /etc/roundcube/config.inc.php:
...
$config['plugins'] = array('automatic_addressbook','acl', ... ... ... );
...

I hope that's of some help even after six months!

[tiurlumbangaol]

hi,

i could make it work on Roundcube version 1.3.9.

cd /var/www/html/plugins/
git clone https://github.com/sblaisot/automatic_addressbook

then running this query on postgresql :
GRANT ALL PRIVILEGES ON TABLE collected_contacts TO databaseuser;
GRANT USAGE, SELECT ON ALL SEQUENCES IN SCHEMA public TO databaseuser;

[mckaygerhard]

PR #26 solves this

[sblaisot]

Sorry for my (very) late reply, I unfortunately no more have the time to maintain this plugin as it deserves.

As far as I know, using the good old rcmail instead of the new rcube is no problem as the rcmail still exist. I just tested it working with roundcube 1.4.2

Installing with composer has not worked very well since the beginning and INSTALL file advice to install from archive. PR are welcome for composer installation problems.

Another known issue is database prefix is not handled correctly at the moment. Any PR about this is also welcome.

[mckaygerhard]

database prefixed will never be automatically addressed.. i talk in past about that in roundcube support and forums, admins must customized if there's any databa prefix set.

yeah .. i changed the rcmail to rcube and now works as i set in the pull request.. just merged and that's all

[sblaisot]

I have tested last automatic_addressbook version with RC 1.4.2 with success. I see no problem with using rcmail.

So can you please explain WHY you want to change rcmail by rcube ? I mean an objective reasons other than "I have done that without knowing what I did" ?
Is there any deprecation notice somewhere in roundcube developer documentation or mailing list about that ?
Can you provide step-by-step instruction that lead to automatic_addressbook plugin not working without changing rcmail with rcube ?
As far as I can see here rcmail class extends rcube class so I can see no reason to call the base framework class rather than the specific webmail class.

[sblaisot]

database prefixed will never be automatically addressed

Database prefix are automatically addressed on plugin installation with composer as you can see here

Unfortunately, they are only adressed for CREATE TABLE and CREATE SEQUENCE statements and not for REFERENCES statements we use in automatic_addressbook plugin. This is a bug that should be addressed in plugin installer and everything should be working with database prefix after that.
I will post a PR on that tomorrow.

[wawefr]

Hello
I have juste an issue with autocomplete which don't work (the reste of the plugin is ok)
Thanks