Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type annotation for instance field expression in OrderBy #200

Open
dhshah opened this issue Oct 11, 2023 · 1 comment
Open

Incorrect type annotation for instance field expression in OrderBy #200

dhshah opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@dhshah
Copy link

dhshah commented Oct 11, 2023 •
edited
Loading

https://github.com/sbdchd/django-types/blob/06da6da7fce4d8bc944e74b403e470ee1eacb57e/django-stubs/db/models/expressions.pyi#L160C32-L160C32

The type annotation should be Expression | F | Subquery instead of Expression (Source)

The related code from django's constructor is self.expression = expression (source)
@sbdchd sbdchd added the bug Something isn't working label Oct 12, 2023
@dhshah
Copy link
Author

dhshah commented Oct 12, 2023

https://github.com/typeddjango/django-stubs/blob/a249686896f9e8d4ae31956bf9d3d9d4d13185db/django-stubs/db/models/expressions.pyi#L254C5-L254C42

Here is the LOC from the original fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhshah @sbdchd