Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up and finish content cards #22

Open
4 of 8 tasks
timothyfcook opened this issue Jul 31, 2015 · 4 comments
Open
4 of 8 tasks

clean up and finish content cards #22

timothyfcook opened this issue Jul 31, 2015 · 4 comments

Comments

@timothyfcook
Copy link
Contributor

  • Pick a good char-limit and truncate text (use "...", later maybe I can go in and clean up data so all descriptions are within our chart-limit)
  • Make boxes a bit wider (so they can be shorter)
  • Set rules so that entire box appears on screen (in some cases, clicking on box made it appear 80% off screen forcing a scroll down ) --- this might be tricky.
  • implement design detail for difficulty: @chelseaerdner and I talked about highlighting the appropriate difficulty panel with green/yellow/red and making any panels above it greyed-out/opaque. For hard difficulty it would show all three: green, yellow, red.
  • Make the background images at tops of cards a little less dark.
  • Card title-hyperlinks should change color w hover
  • remove word "Activity" before local/digital type
  • if age range reads e.g. "9 - 90", change it to show just "9+"
@cameronscott137
Copy link

Completed:

  • Resource descriptions have been truncated to 300 chars, and Org descriptions have been truncated to 150.
  • Popover widened to 300px
  • Popover overlay opacity lightened
  • Adds hover state to popover title link
  • Removes word "activity" before local/digital type
  • 9–90 age range now reads "9+."

To-Do

  • Set rules so that entire popover appears on screen. You're right @timothyfcook, this is gonna be a bit tougher. Splitting this out to a separate issue.
  • Implement design detail for difficulty. This isn't big, but since it'll require @chelseaerdner's input, too, going to split it out to separate issue.

@timothyfcook
Copy link
Contributor Author

I'm still seeing:

  • remove word "Activity" before local/digital type
  • if age range reads e.g. "9 - 90", change it to show just "9+"

@cameronscott137
Copy link

Both updated. Just needed to commit the view.

Keep in mind, only resources labeled 9–90 will show up as 9+. There are resources in the mix that are 10–90 and 11–90, as well. When we begin to utilize user data, will want to provide a dropdown or some similar way to enforce consistency, but in the interim, I can account for those cases, as well?

@timothyfcook
Copy link
Contributor Author

Ah, yeah. Can we do it so that any age range that has a " - 90" in it is replaced with "+" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants