Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and documentation for arithmetic overflow #8

Open
saxbophone opened this issue Sep 23, 2021 · 0 comments
Open

Testing and documentation for arithmetic overflow #8

saxbophone opened this issue Sep 23, 2021 · 0 comments

Comments

@saxbophone
Copy link
Owner

saxbophone commented Sep 23, 2021

Arithmetic overflow can occur in the following scenarios:

  • Addition
  • Subtraction
  • Multiplication
  • Division
  • Increment
  • Decrement
  • Creating PSXFixed from a double or from_integer() where the input is outside the bounds of the fixed-point type

Currently, the behaviour of overflowing operations is unspecified. It should be specified, tested for, and documented, regardless of whether we decide to catch it or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant