Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support results of the contests #1035

Closed
orchestr7 opened this issue Aug 12, 2022 · 2 comments
Closed

Properly support results of the contests #1035

orchestr7 opened this issue Aug 12, 2022 · 2 comments
Assignees
@sanyavertolet

Comments

@orchestr7
Copy link
Member

orchestr7 commented Aug 12, 2022 •
edited
Loading

  1. All contest run results should be properly stored in a database and linked to the project. This should be elegantly be done in the same manner as execution history is done - the best scenario is when we reuse all the related logic to existing run:
  • You can have a normal execution run;
  • Have a table for contest results with links to these execution - something like this: Score, ExecutionId, Contest ;
  • As executions are linked to the project already - there will not be any problems to show/calculate total score for the project on the frontend. Also it will be easy to find the champion in contests and show results dashboard on the contests page.
  1. We need to fill in two tabs on contests View:
  • Participants (a good example is here);
  • Results only for your projects. That is a tough task, because you we need to show results for all projects where user is added. For example - if user added to both diktat and ktlint and both of them were participating in contests - we should show them.
sanyavertolet added a commit that referenced this issue Aug 22, 2022
@sanyavertolet
ContestView results improvements
d54843c 
### What's done:
 * Renamed `PARTICIPANTS` ContestView tab to `SUMMARY`
 * Renamed `RESULTS` ContestView tab to `SUBMISSIONS`
 * Improved `SUBMISSIONS` tab
 * Added `ContestExecutionView`
 * Added several endpoints on backend for new tab and view

 (#1035)
sanyavertolet added a commit that referenced this issue Aug 22, 2022
@sanyavertolet
Small fixes
3fb5f9e 
### What's done:
 * Renamed `PARTICIPANTS` ContestView tab to `SUMMARY`
 * Renamed `RESULTS` ContestView tab to `SUBMISSIONS`
 * Improved `SUBMISSIONS` tab
 * Added `ContestExecutionView`
 * Added several endpoints on backend for new tab and view

 (#1035)
@sanyavertolet sanyavertolet mentioned this issue Aug 22, 2022
Merged
sanyavertolet added a commit that referenced this issue Aug 22, 2022
@sanyavertolet
Test fixes
f0fba0a 
### What's done:
 * Renamed `PARTICIPANTS` ContestView tab to `SUMMARY`
 * Renamed `RESULTS` ContestView tab to `SUBMISSIONS`
 * Improved `SUBMISSIONS` tab
 * Added `ContestExecutionView`
 * Added several endpoints on backend for new tab and view

 (#1035)
sanyavertolet added a commit that referenced this issue Aug 22, 2022
@sanyavertolet
Test fixes
f96d671 
### What's done:
 * Renamed `PARTICIPANTS` ContestView tab to `SUMMARY`
 * Renamed `RESULTS` ContestView tab to `SUBMISSIONS`
 * Improved `SUBMISSIONS` tab
 * Added `ContestExecutionView`
 * Added several endpoints on backend for new tab and view

 (#1035)
sanyavertolet added a commit that referenced this issue Aug 22, 2022
@sanyavertolet
Test fixes
ca6f1f4 
### What's done:
 * Renamed `PARTICIPANTS` ContestView tab to `SUMMARY`
 * Renamed `RESULTS` ContestView tab to `SUBMISSIONS`
 * Improved `SUBMISSIONS` tab
 * Added `ContestExecutionView`
 * Added several endpoints on backend for new tab and view

 (#1035)
sanyavertolet added a commit that referenced this issue Aug 22, 2022
@sanyavertolet @petertrr
ContestView results improvements (#1081)
90412be 
* ContestView results improvements

### What's done:
 * Renamed `PARTICIPANTS` ContestView tab to `SUMMARY`
 * Renamed `RESULTS` ContestView tab to `SUBMISSIONS`
 * Improved `SUBMISSIONS` tab
 * Added `ContestExecutionView`
 * Added several endpoints on backend for new tab and view

 (#1035)

Co-authored-by: Peter Trifanov <[email protected]>
@sanyavertolet
Copy link
Member

sanyavertolet commented Aug 26, 2022 •
edited
Loading

@akuleshov7 does it look good enough to be new participants tab?
screenshot

sanyavertolet added a commit that referenced this issue Aug 26, 2022
@sanyavertolet
ContestSummaryMenu improvements
9c1672e 
### What's done:
 * Slightly improved `ContestSummaryMenu`
 * Fixed styles for execution labels for non-contest executions.

(#1035)
@sanyavertolet sanyavertolet mentioned this issue Aug 26, 2022
Merged
sanyavertolet added a commit that referenced this issue Aug 26, 2022
@sanyavertolet
ContestSummaryMenu improvements
6bd8557 
### What's done:
 * Slightly improved `ContestSummaryMenu`
 * Fixed styles for execution labels for non-contest executions.

(#1035)
sanyavertolet added a commit that referenced this issue Aug 26, 2022
@sanyavertolet
ContestSummaryMenu improvements (#1108)
64470c7 
### What's done:
 * Slightly improved `ContestSummaryMenu`
 * Fixed styles for execution labels for non-contest executions.

(#1035)
nulls pushed a commit that referenced this issue Aug 29, 2022
@sanyavertolet @nulls
ContestSummaryMenu improvements (#1108)
f1a8a72 
### What's done:
 * Slightly improved `ContestSummaryMenu`
 * Fixed styles for execution labels for non-contest executions.

(#1035)
@sanyavertolet
Copy link
Member

The frontend part is done with #1081 and #1108. Backend part will be done as #1115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanyavertolet sanyavertolet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanyavertolet @orchestr7