-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inline fixers for fix and warn plugin #221
Comments
What's done: * Added support inline fixers for fix and warn plugin Closes #221
Bad news are the following:
|
The check_clang_tidy.py script provides an easy way to test both diagnostic messages and fix-its. It filters out CHECK lines from the test file, runs clang-tidy and verifies messages and fixes with two separate FileCheck invocations: once with FileCheck’s directive prefix set to CHECK-MESSAGES, validating the diagnostic messages, and once with the directive prefix set to CHECK-FIXES, running against the fixed code (i.e., the code after generated fix-its are applied). In particular, CHECK-FIXES: can be used to check that code was not modified by fix-its, by checking that it is present unchanged in the fixed code. The full set of FileCheck directives is available (e.g., CHECK-MESSAGES-SAME:, CHECK-MESSAGES-NOT:), though typically the basic CHECK forms (CHECK-MESSAGES and CHECK-FIXES) are sufficient for clang-tidy tests. Note that the FileCheck documentation mostly assumes the default prefix (CHECK), and hence describes the directive as CHECK:, CHECK-SAME:, CHECK-NOT:, etc. Replace CHECK by either CHECK-FIXES or CHECK-MESSAGES for clang-tidy tests. |
What's done: * Added support inline fixers for fix and warn plugin Closes #221
What's done: * Added support inline fixers for fix and warn plugin Closes #221
What's done: * Added support inline fixers for fix and warn plugin Closes #221
What's done: * Added support inline fixers for fix and warn plugin Closes #221
What's done: * Change test storage from List to class in plugin Closes #221
What's done: * Change test storage from List to class in plugin Closes #221
What's done: * Change test storage from List to class in plugin Closes #221
What's done: * Change test storage from List to class in plugin Closes #221
What's done: * Change test storage from List to class in plugin Closes #221
What's done: * Change test storage from List to class in plugin Closes #221
What's done: * Change test storage from List to class in plugin Closes #221
@akuleshov7 btw, why it still pinned? I think we can drop it for now |
We need to support the following LIT fixers:
https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/test/clang-tidy/checkers/abseil-time-comparison.cpp
We need to:
Expected
test resourceThis should be done under
inlineFixer = true
optionKeep in mind, that in warn plugin you already have the list with warnings matched to lines, may be it could help you
The text was updated successfully, but these errors were encountered: