Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Profile card skeleton loading #9

Open
ParasSolanki opened this issue Nov 13, 2024 · 2 comments
Open

[Feature]: Profile card skeleton loading #9

ParasSolanki opened this issue Nov 13, 2024 · 2 comments

Comments

@ParasSolanki
Copy link

It would be nice to have a skeleton loading UI while we are fetching profile details.

@saurabhdaware
Copy link
Owner

I thought of that and had implemented it in earlier version though the tricky part is that we don't know height and width of the card before the data is fetched so we don't know how much space to reserve for that skeleton.

So when I had a loading screen earlier, it was causing very weird UX where loading screen is not in the same height / width as widget card so the card visually shifts.

People can define the height width on consumer-side too but that too might not be very accurate and its still an optional step.

Plus I checked API response time of bluesky's getProfile API and its fairly fast so if you have the card somewhere on lower folds, its unlikely that you'll ever see the loading state

@ParasSolanki
Copy link
Author

Yeah, skeleton UI will be tricky in this case.

So when I had a loading screen earlier, it was causing very weird UX where loading screen is not in the same height / width as widget card so the card visually shifts.

The main issue will be from description cause we don't know how long it will be and it will cause jump which is not good.

Plus I checked API response time of bluesky's getProfile API and its fairly fast so if you have the card somewhere on lower folds, its unlikely that you'll ever see the loading state

image

They are caching it for 30 seconds which is not a lot but as you mentioned that there API is fast so widget will render very quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants