Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile card add fallback UI for missing banner and avatar images #8

Open
ParasSolanki opened this issue Nov 13, 2024 · 1 comment
Open

Profile card add fallback UI for missing banner and avatar images #8

ParasSolanki opened this issue Nov 13, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ParasSolanki
Copy link

Current version of the component does not properly handle a case when profile handle does not have a banner image or profile image.

image

Solution

When there is no banner image we should fallback to background color and for avatar image use svg icon.

image
@saurabhdaware
Copy link
Owner

Oh I think I handle having no banner but not handling having no profile picture. Thanks for reporting.

@saurabhdaware saurabhdaware added bug Something isn't working good first issue Good for newcomers labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saurabhdaware @ParasSolanki