-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support social logins #8
Comments
This could potentially be sub-plugins or be installed via flags: Or we can just have multiple generators, now that I think about it: That actually does bring another issue up, naming and 'namespacing' of the generators. Right now only I am also thinking here how the What do you think? @kriswill you had an idea about that as well I believe? |
As far as naming goes, I don't think it's that important. Some people will want to find things by name, but ultimately it comes down to the module possessing the correct dependency on For the sane-auth addon module, I think they can work similarly to how ember-simple-auth works, in that they simply reside at the same level as sane-auth, and aren't a hierarchy. something like: Package.json:{
"devDependencies": {
"sane-auth": "*",
"sane-auth-social-core": "*",
"sane-auth-social-twitter": "*",
"sane-auth-social-facebook": "*"
}
} |
I tend to think sane- is a good prefix for sake of discovery, but it is true that the keyword serves that purpose as well as install |
No description provided.
The text was updated successfully, but these errors were encountered: