Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 401 instead of 500/400 for empty logins #19

Open
givanse opened this issue May 15, 2015 · 0 comments
Open

use 401 instead of 500/400 for empty logins #19

givanse opened this issue May 15, 2015 · 0 comments

Comments

@givanse
Copy link
Contributor

givanse commented May 15, 2015

Loggin in without a user or password returns:

http://localhost:4200/api/v1/auths/login 500 (Internal Server Error)

Wrong user or password returns:

http://localhost:4200/api/v1/auths/login 400 (Bad Request)

It should have been a 401 Unauthorized
@givanse givanse changed the title use 401 instead of 500 for empty logins use 401 instead of 500/400 for empty logins May 15, 2015
givanse added a commit to givanse/sane-auth that referenced this issue May 19, 2015
@givanse
fix sane#19 use 401 instead of 400 for failed logins
7a3dd50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@givanse