Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install and upgrade challenges #13

Open
jamemackson opened this issue May 5, 2015 · 6 comments
Open

install and upgrade challenges #13

jamemackson opened this issue May 5, 2015 · 6 comments

Comments

@jamemackson
Copy link

In testing this out, so far I've got what's here now working (win!) but in the process I realized just how much view content that is created in the installation process. This is great for the end user but I think also adds it challenges to the add-on.

The main challenges I'm seeing are that
a) we're currently assuming the destination site is using bootstrap
and then
b) how will upgrades possibly work and not overwrite a users inevitable customizations?

Maybe you guys are already thinking about this but thought I'd mention it anyways...

@jamemackson
Copy link
Author

ok I'm retracting the bootstrap challenge. :) I saw the 'form-control' class on input fields but overall I guess it's not really all that bootstrap specific html... the upgrade one I still stand by though :P

@mgenev
Copy link
Member

mgenev commented May 5, 2015

I'm assuming upgrades can be like Ember's - overwrite or diff then manual merge... I can't think of another way

@jamemackson
Copy link
Author

And here I didn't even realize they had a diff option! That sounds like a good option, I'll have to look for that next time I run an ember upgrade!

@jamemackson
Copy link
Author

Interestingly enough I was just reading up on ember-cli-admin and noticed that it looks like they are leveraging the resolvers hierarchy to allow the user to override their default view templates by placing a "override" view higher up in the search hierarchy. This seems like a decent strategy to consider here too.
https://github.com/ember-admin/ember-cli-admin#global-overrides

@Globegitter
Copy link
Member

The diff approach is currently supported with sane-cli. So if the file already exists it tries to generate it will give you the option to diff/overwrite/not-overwrite.

But global defaults and overrides sound like a pretty good approach. So the ember-cli-admin app provides default views in the app folder, is that how this works?

@jamemackson
Copy link
Author

While I haven't dug into the details in practice, here is their documentation describing it: https://github.com/ember-admin/ember-cli-admin#customize-templates

AFAIK, I think they put their default views into their add-on and then allow the developer to override their defaults by creating views in the core project file structure. I have this on my list to dig into the details of so unless someone else has better info sooner, I will report back here once I've done that digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants