Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler should be instantiated and standardized by Suite #1

Open
dskvr opened this issue Nov 2, 2024 · 0 comments · May be fixed by #7
Open

Sampler should be instantiated and standardized by Suite #1

dskvr opened this issue Nov 2, 2024 · 0 comments · May be fixed by #7
Labels
enhancement New feature or request

Comments

@dskvr
Copy link
Contributor

dskvr commented Nov 2, 2024

Right now, each Suite Test has it's own sampler, however, other than being slow, this means that data cannot be shared between Suite Tests. So instead, the Sampler should be instantiated in the Suite, where the interface of the expected Sampler state lives.

Additionally, right now the Sampler only accepts a single ingestor, but should accept multiple. Additionally, the ingestors should have access to the Sampler state and be able to be ordered. Refactoring this is trivial.

The result is faster tests, way more capability, easier on relays and can fail faster.

Note: This could be taken a step further and passed up to the auditor, but this would likely warrant standardization between Suites, which could prove extremely difficult.

@dskvr dskvr added the enhancement New feature or request label Nov 2, 2024
@dskvr dskvr linked a pull request Nov 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant