Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signedness for fields that should only represent positive values such as lengths #460

Closed
wants to merge 3 commits into from
Closed

Signedness for fields that should only represent positive values such as lengths #460

wants to merge 3 commits into from

Commits on Dec 10, 2019

  1. Revisiting signedness for fields that should only represent positive … 

    …values such as lengths
    @brainstorm
    brainstorm committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    5afde85 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Rollback unrelated footnote about cCsSiI BAM fields

    @brainstorm
    brainstorm committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    3355653 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. [SQUASH ME] Added additional text explaining 31-bit vs 32-bit size li… 

    …mits.

The main tables should describe sign and on-disk sizes, which they now
do, but on disk size is not the same thing as range of valid values.

I feel this is clearer than the alternative option of keeping some as
int32_t and needing to define their valid ranges.
    @jkbonfield
    jkbonfield committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    535dc6b View commit details
    Browse the repository at this point in the history