Chocolatey as requisite in SLS

[alekseyl1992]

My SLS file:

chocolatey:
  pkg.installed:
    - require:
      - pkg: dotnet

visualstudio2015professional:
  chocolatey.installed:
    - require:
      - pkg: chocolatey

when I run highstate I get:

          ID: chocolatey
    Function: pkg.installed
      Result: False
     Comment: The following packages failed to install/update: chocolatey=0.9.9
     Started: 17:00:22.464000
    Duration: 7612.0 ms
     Changes:
              ----------
              chocolatey:
                  ----------
                  install status:
                      success
----------
          ID: visualstudio2015professional
    Function: chocolatey.installed
      Result: False
     Comment: One or more requisite failed: tester.chocolatey
     Started:
    Duration:
     Changes:

please note that:

1. chocolatey actually installs and works
2. it even returns:

                  install status:
                      success

3. but salt treats this as error:
   packages failed to install/update

I tried both installing chocolatey via chocolatey.bootstrap or using SLS as stated above. Both times choco installed and worked just fine.

May be that's because it:
https://github.com/saltstack/salt-winrepo-ng/blob/master/chocolatey.sls
actually installs the latest choco, which is 0.10, not 0.9.9 as mentioned in registry keys.

I know there is another issue about choco exit codes:
saltstack/salt#34099

but that issue bescribes installing software with choco, whereas my - installing choco itself.

salt 2016.3.2 (Boron)
salt-minion 2016.3.2 (Boron)
minion os: Windows 7

[TheBigBear]

@alekseyl1992 thanks for reporting this. I think I know what the issue is. It is a combination of factors, most likely.
I will look at this, as I am bale, but it might potentially take into beginning or even middle of September, sorry.

In a nutshell the winrepo sls files for chocolatey are VERY out of date. And I need to re-align things with the new chocolatey and how it installs itself and registers itself in the registry and replicate that in salt, so that either a choc or salt pkg management will do the "same" thing.

[TheBigBear]

@alekseyl1992 can I close this? I think it works now, right? It was a chocolatey version number issue, but we are currently 'up to date' with latest and it works, right?

[TerraTalpi]

Hey @TheBigBear, since opening this issue there have been 16 merged pull-requests for chocolatey and @alekseyl1992 did not reply. I think we can consider this as fixed ans close the issue, right?

[alekseyl1992]

Sorry, haven't used salt on windows since then.
So yes, closing a stale issue is ok.