Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursive requisite for salt 3007 #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

didiermfb
Copy link

@didiermfb didiermfb commented May 14, 2024

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

With Salt 3007 since a recence change in Salt 3007 the formula results send this message :

       ----------
                 ID: rabbitmq-config-plugins-rabbit-rabbitmqadmin-install
           Function: cmd.run
               Name: curl -k -L http://127.0.0.1:15672/cli/rabbitmqadmin -o /usr/local/sbin/rabbitmqadmin
             Result: False
            Comment: Recursive requisite found
            Changes:   
       ----------

#137

Describe the changes you're proposing

Remove the require of sls file and put states in the require instead.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@didiermfb didiermfb changed the title Fix Recursive requisite for Salt 3007 fix: Recursive requisite for Salt 3007 May 14, 2024
@didiermfb didiermfb force-pushed the fix/recursive_requisite branch from cf22b0f to 65803f9 Compare May 14, 2024 12:42
@dafyddj
Copy link
Contributor

dafyddj commented May 14, 2024

Hi, the capital R in the commit message needs to be lower case

@didiermfb didiermfb force-pushed the fix/recursive_requisite branch from 65803f9 to c1cfea6 Compare May 14, 2024 14:11
@didiermfb
Copy link
Author

Hi, the capital R in the commit message needs to be lower case

Thanks, I just saw that. Commit message edited.

@didiermfb didiermfb changed the title fix: Recursive requisite for Salt 3007 fix: recursive requisite for salt 3007 May 14, 2024
@didiermfb
Copy link
Author

This seems to resolve the issue with recursive but impact the creation of the 2nd node :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants