Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or replace Tether / Drop #951

Closed
interactivellama opened this issue Mar 30, 2017 · 1 comment · Fixed by #1140
Closed

Remove or replace Tether / Drop #951

interactivellama opened this issue Mar 30, 2017 · 1 comment · Fixed by #1140

Comments

@interactivellama
Copy link
Contributor

interactivellama commented Mar 30, 2017

Tether / Drop is old and hasn't been updated in two years. Recently, a team tried to render a tootlip on the server. Shallow renders don't work with Tether / Drop either (for instance in Jest testing).

Testing:

  • Needs to work in Modals (z-index, render in inside portalMount)
  • Needs to be able to flip based on viewport.
  • Needs to render in Snapshots and server (no DOM environments)

See Dialog component for more details.

This might be a temporary solution: HubSpot/drop#155
This React port https://github.com/souporserious/react-popper of https://github.com/FezVrasta/popper.js might be a pretty robust solution.

Stale inactive WIP branch with partial implementation: #1022

@interactivellama interactivellama added this to the backburner milestone Mar 30, 2017
@interactivellama interactivellama changed the title Remove Tether / Drop Remove or replace Tether / Drop Apr 5, 2017
@interactivellama interactivellama modified the milestones: backlog, backburner Jul 5, 2017
@futuremint futuremint removed this from the backlog milestone Jul 11, 2017
@futuremint
Copy link
Contributor

futuremint commented Jul 11, 2017

Here is my first attempt: master...futuremint:remove-tether-react-popper
That uses react-popper and changes Dialog to render both the target and the "popper", however while working on menu-dropdown this approach ended up being problematic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants