Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

oauth2 support? #110

Open
kamado-tanjiro-usa opened this issue Apr 16, 2019 · 2 comments
Open

oauth2 support? #110

kamado-tanjiro-usa opened this issue Apr 16, 2019 · 2 comments

Comments

@kamado-tanjiro-usa
Copy link

Hi there, doesn't look like it supports oauth 2, and in fact it's adding legacy=1 unnecessarily?
legacyString = "?legacy=1"
if legacyString not in self.auth_url:
self.auth_url = self.auth_url.strip()
self.auth_url = self.auth_url + legacyString

On top of that, it's not providing 'grant_type'

It'll be nice if you guys can provide an update to the SDK so we can use it as an abstract layer over the SOAP part of the API

Thanks!

@kamado-tanjiro-usa
Copy link
Author

for auth I"m seeing

            payload = {'clientId' : self.client_id, 'clientSecret' : self.client_secret, 'refreshToken' : self.refreshKey, 'accessType': 'offline'}

there is no grant_type

so when'll we get support for v2?

@kamado-tanjiro-usa
Copy link
Author

line 201

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant