Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When freecamming with a Figura avatar, all you see is the inside of your vanilla skin's head #69

Open
davie53 opened this issue Nov 21, 2024 · 4 comments
Labels
other mod problem The problem lies with another mod

Comments

@davie53
Copy link

davie53 commented Nov 21, 2024

I don't think this is a Figura issue (though I will be reporting this to them as well), because I used the 0.1.5-rc.4 version when testing both in 1.21.1 with the release version of Tweakeroo, and in 1.21.3 with this dev version of Tweakeroo, and the issue did not arise when using 1.21.1. I also tested this with multiple Figura avatars.

2024-11-21_16 04 27

The image above is what I saw (yes, the head of my skin looks like an emerald block), I could look up or down to make the camera clip out of the head slightly, but this is clearly a problem.
Also, I will be making another issue about the "tweakeroo.config.generic.prettyName.freeCameraPlayerMovement", as that is a different issue altogether.

Strangely enough when I did this on a server with my modpack that has a ton of mods, my game crashed. I will try to find which mod made it crash, but for now, this will have to do.

@davie53
Copy link
Author

davie53 commented Nov 22, 2024

I have figured out what causes the crash on the server, it's the fact that if you're on a team with /team add <team_name> and /team join <team_name> and have a Figura model on, then the game crashes. I have here a crash report:
crash-2024-11-22_14.44.25-client.txt
I hope this helps!

@sakura-ryoko
Copy link
Owner

sakura-ryoko commented Nov 22, 2024

The Crash is related to your mod 'Figura', not Tweakeroo.

java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1297.method_5667()" because the return value of "net.minecraft.class_638.method_8469(int)" is null
	at knot//net.minecraft.class_1007.modify$bae000$figura$modifyPlayerNameText(class_1007.java:615)

@sakura-ryoko sakura-ryoko added the other mod problem The problem lies with another mod label Nov 22, 2024
@davie53
Copy link
Author

davie53 commented Nov 22, 2024

When trying this with the release version of Tweakeroo on Modrinth with Figura v0.1.5-rc4 for 1.21.1 this issue didn't occur. When using the version of Tweakeroo on this Github with Figura v0.1.5-rc4 for 1.21.3 this issue occurred. I have also reported this to the Figura devs, but it seems that something changed with this version of Tweakeroo.
But I guess mod compatibility isn't really a huge concern with the development builds, particularly not when both mods are dev builds, so I understand if this isn't something you're planning on fixing.

@UnlikePaladin
Copy link

Figura's latest build is very much stable, it's just getting the id from the player render state, which is a vanilla field and should not be null. This is a tweakeroo issue, not an us problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other mod problem The problem lies with another mod
Projects
None yet
Development

No branches or pull requests

3 participants