Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions on SOLID principles #1

Open
Betancourt1996 opened this issue Nov 22, 2020 · 0 comments
Open

Suggestions on SOLID principles #1

Betancourt1996 opened this issue Nov 22, 2020 · 0 comments

Comments

@Betancourt1996
Copy link

Hello, these are some suggestions to implement some solid principles.
a class should handle the calculation of Sailors salaries.
some functions like randSailorid must have a Sailor object as a parameter in order not to be used by other classes.
When adding passengers, other types of passengers such as animal passengers are left aside, so it is recommended to create a parent class "Passengers" to use "HumanPassengers" "AnimalPassengers", or any other that may be presented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant