-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wires don't appear even with enableWireResend enabled #1
Comments
I would like to get a minimal server which reproduces the issue. If it is possible, you need to copy your server and start removing everything one by one (datapacks, plugins, etc.), except LeadWires. That way you either will find which plugin may cause problems, or get a minimal server bundle, and send it to me. If you don't want to send a server bundle, I can debug with you in real time in Discord, but that way I can not guarantee that I will have time soon to do this. Also, info required:
|
I can't really provide a "minimal" server setup here. I could - at most - give the domain so that you could join and see it yourself. To answer some of your questions:
Even with the world now changed does the issue appear at random. It also seems to happen that the Silverfish don't appear at all or they do appear but with no leash attached to them. |
No, LW constructs and sends packets by itself, the spigot (and therefore other plugins) don't know about these entities.
Looks like the client is ignoring packets, either entity spawn packet or entity attach packet. I will try to reproduce the issue with Multiverse plugin, but most likely I will fail to reproduce it. Then I implement a command to resend wires to player, so you can test, whether a resend fixes the problem. If it does, I will implement another workaround like continious resend (respawn all wires every sec lol). |
I could't reproduce the issue with Multiverse plugin. Anyway, I've implemented If the command works, I will implement some workaround like continous respawn, as I said earlier. To get new version of the plugin, you can build it from this repo (instructions are available in README.md). Until this issue is resolved, modified plugin will not be available on SpigotMC. If you can't build the plugin, I can give you prebuilt version. |
The command does make the wires appear again. How do you actually track if players are near a leads (spawn) location to display/respawn the lead? |
The plugin listens for outgoing chunk send/chunk unload packets to track chunks that are visible (loaded) to a player. When a new chunk loads, the plugin checks any wires that will become visible (wire is visible, when both of its ends are in visible chunks), and sends them. On chunk unload the plugin detects wires that became invisible and despawns them. Since the plugin correctly shows chunk count and respawn command works, the problem is not with chunk visibility tracking. I think the client may be ignoring entity spawn or entitiy attach packets, because chunk is not yet processed by the client somehow (LW sends entity packets immediately after chunk packet). This may explain why I can't reproduce the issue on my local server, where worlds are simple and there is no network lag, but that's not the case on production servers (yours and other guy, who had the same problem). Anyway, exact cause is unknown to me. Since the command is working, I will implement wire respawn timer and an option to enable it in config. |
Hmmm okay. |
I've impemented respawn timer. Add this to config.yml:
If it works, I will release this plugin version on SpigotMC. Also, I will implement wire view distance somewhere in the future, because it looks like spawning anything in chunks on the edge of player view distance is a bad idea. This may fix all problems with wires disappearing and remove need for ugly workarounds like respawn timer. |
The issue
I encounter the issue, where wires set aren't appearing (silverfish don't spawn and no lead is visible).
Even having
enableWireResend
set to true doesn't fix this issue.Context and steps
The wires, in particular, are saved in a separate world that I have to teleport to first (will change in the future).
The world is called spawn and here's the content of the wires.txt
All wires in hub are perfectly fine.
Steps to reproduce (I guess):
Info
The text was updated successfully, but these errors were encountered: